[5.0] Add argument to cache:clear to specify store name. #7930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->cache->flush(); | ||
| try { | ||
| $cacheStore = $this->cache->store($storeName); | ||
| } catch (\InvalidArgumentException $e) { |
There was a problem hiding this comment.
What's the advantage to letting it bubble instead of displaying a succinct message to the user?
There was a problem hiding this comment.
The message should already be succinct?
There was a problem hiding this comment.
For example, we throw an exception when a command is not found, and that's totally readable.
There was a problem hiding this comment.
There was a problem hiding this comment.
I forgot how exceptions were rendered out, that's perfect. I'll change it.
willrowe
force-pushed
the
add-cache-clear-argument
branch
from
6ea0a5e to
f1c12d6
Compare
|
Try/catch block removed. |
taylorotwell
added a commit
that referenced
this pull request
Mar 11, 2015
[5.0] Add argument to cache:clear to specify store name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the delay. This is #7893 retargeted for 5.0.
This adds an argument to the
cache:clearcommand so that you can specify the store that will be cleared. If nothing is passed it will clear the default store as it normally does. Tests included.