[4.2] Annotate Psr\Log\LoggerInterface as provided by LogServiceProvider. #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Psr\Log\LoggerInterface was added to app->bind but not added to the provides array in the LogServiceProvider. See: itsgoingd/clockwork#67
spencerdeinum
changed the title
|
👍 |
|
👍 yup. |
taylorotwell
added a commit
that referenced
this pull request
Oct 16, 2014
…e_provider [4.2] Annotate Psr\Log\LoggerInterface as provided by LogServiceProvider.
|
Any ETA on a 4.x release with this fix included? |
|
I don't know if any of the 4.2 bugs are blocking the tag. |
|
I'm still pinned at 4.2.9 until a new release is cut. |
|
No, we're at v4.2.11: https://github.com/laravel/framework/releases. Related issue: #6200. |
|
Oh, do you mean you can't upgrade until this is included in a tag? |
|
Same here as @spencerdeinum, 4.2.11 doesn't have the fix included and that release has been pushed a while ago now. @GrahamCampbell: yep :) |
|
@quagh @spencerdeinum @GrahamCampbell FYI: Taylor just tagged 4.2.12 which will contain this bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Psr\Log\LoggerInterface was added to app->bind but not added to the
provides array in the LogServiceProvider.
See: itsgoingd/clockwork#67