Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add tests to Dispatcher class #34940

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented Oct 23, 2020

While playing around with Dispatcher internals for optimization purposes, I found that this behavior is tested nowhere else and I was able to ruin it with no failing test.

One relates to where we continue appending listeners after we fired the event.
The second one defines what happens if a listener setups for listeners for its own event.

@taylorotwell taylorotwell merged commit dae0cb9 into laravel:8.x Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants