[6.x] Broadcaster - Improve ShouldBroadcastNow performance #30797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
ShouldBroadcastNow
sends theBroadcastEvent
to thesync
queue. This causes some performance issues:BroadcastEvent
SerializesModels
Trait it creates completely unnecessary database queriesSolution
We could just directly
dispatchNow()
theBroadcastEvent
. There should be no reason at all to send it to the thesync
queue.