[6.x] Allow commands to overwrite their input and output handlers #30706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gocanto
changed the title
|
Please use fully qualified class names in the phpdoc, and put 2 spaces around the type in param docs. |
|
Sure thing Graham. I will get to it tomorrow! |
GrahamCampbell
changed the title
|
@GrahamCampbell I think these commits should do the trick. Thanks! |
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
[PR]allows commands to overwrite the input and output handlers.This is useful when you need to swap out a current handler on runtime execution. It also adds an easy way to test commands as
Unitswithout the need to extend from theframeworktest case class to write tests as it is in here.There is another way to hook into this cycle by
mockingtheLaravelvalue, but you need to get into setting all the expectations needed as shown in this Test