Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryException expects the previous exception to be a PDOException - if it's not, the exception itself causes a fatal error because
$previous->errorInfo
is not defined. By adding an if check to the QueryException's constructor it should work with normal Exceptions as well. Alternatively, if a connection statement being ran causes an exception that's not a PDOException it could just be passed on through the app - i.e. only catch PDOExceptions, not all exceptions.Common causes that would be helped by this would be if you have incorrect statement bindings - for example, trying to pass a multidimensional array as query bindings. However, in this case, formatMessage will fail becase str_replace_array won't accept multidimensional arrays either, but at least the exception will have a decent stack trace. Replacing multidimensional arrays with the word 'Array' could be a possible fix for this when debugging - thoughts?