Trying HHVM builds on Travis CI #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @ptarjan |
|
Nice! you can remove the allow hhvm failures :) |
|
I'd consider leaving it allowed. I expect bugs may crop up in HHVM that might throw Laravel contributions off. |
|
If bugs crop up, wouldn't it be better to fix them so HHVM can be fully supported? |
|
They should be fixed in HHVM, assuming the project passes on the official PHP interpreters. |
|
@RSully Agreed, but they also provided a way to bypass it until it does get implemented upstream. So if HHVM is to be support you would theoretically |
taylorotwell
added a commit
that referenced
this pull request
Dec 19, 2013
Trying HHVM builds on Travis CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests with hhvm: http://about.travis-ci.org/blog/2013-12-16-test-php-code-with-the-hiphop-vm/