-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.8] allow whereNull
and whereNotNull
to accept array columns argument
#29154
[5.8] allow whereNull
and whereNotNull
to accept array columns argument
#29154
Conversation
whereNull
to accept array columns argumentwhereNull
and whereNotNull
to accept array columns argument
whereNull
and whereNotNull
to accept array columns argumentwhereNull
and whereNotNull
to accept array columns argument
Should probably target master since the method signature changes. |
It isn't a breaking change in this case so 5.8 is fine. Nice idea! |
How is this not a breaking change? |
Probably rare but if you're overriding whereNull, your app will blow up after this change. |
If you’re overriding whereNull then you’re already aware of what you intend to pass into it. |
@devcircus The method signature didn't change, only the PHPDoc and the parameter name. This doesn't affect methods overriding |
learned something today. i've never once attempted to change the name of a parameter when overriding. Always assumed the names were as much a part of the signature as the types. Thanks @staudenmeir |
This PR adds the ability to pass an array of columns to the for
whereNull
andwhereNotNull
queries.an example of the use case,
Before
After
and let's face it, who doesn't?