Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Annotation hints for softDeletes #28352

Merged
merged 2 commits into from
Apr 28, 2019
Merged

[5.8] Annotation hints for softDeletes #28352

merged 2 commits into from
Apr 28, 2019

Conversation

xiaohuilam
Copy link
Contributor

Description
Currently, some php ide does not hint the methods SoftDeletes trait macroed.

Demo
image

@xiaohuilam
Copy link
Contributor Author

related laravel/ideas issue laravel/ideas#1593

@taylorotwell taylorotwell merged commit a752ffa into laravel:5.8 Apr 28, 2019
@GrahamCampbell GrahamCampbell changed the title annotation hints for softDeletes [5.8] Annotation hints for softDeletes May 8, 2019
@xiaohuilam xiaohuilam mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaohuilam @taylorotwell