Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct note upsert #7406

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Correct note upsert #7406

merged 2 commits into from
Nov 1, 2021

Conversation

l3aro
Copy link
Contributor

@l3aro l3aro commented Nov 1, 2021

When digging deeper to upsert func, I find that MySqlGrammar has no use with params uniqueBy, but SqlServerGrammar do, as image below. After some investigate around google, I think this is a mistake in the documentation, not the source code.

image
image

@taylorotwell
Copy link
Member

Deleting the whole comment because I'm tired of PRs from people changing it back and forth. 😅

@taylorotwell taylorotwell merged commit 9e822ba into laravel:8.x Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants