[Cashier] Missing mandatory parameters to downloadInvoice #7173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't correct. In the latest v13 these aren't required anymore. |
driesvints
added a commit
that referenced
this pull request
Jul 7, 2021
)" This reverts commit f029542.
|
I suspected because I had seen the modification on the documentation. But I haven't found this anywhere in code base on 13.x branch. Maybe I missed it. |
|
@matthieumota I'm sorry but you're correct. This is still required. I forgot to assign new defaults while working on v13 🤦♂️ |
|
I'm ok to open PR but I don't know what default values to product and vendor, maybe |
|
I'll take care of it in the next release 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is a little typo about
downloadInvoice(), method needsdataarray parameter with at leastvendorandproductkeys.