Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc chat content fields #343

Merged
merged 3 commits into from
Jan 5, 2024
Merged

doc chat content fields #343

merged 3 commits into from
Jan 5, 2024

Conversation

pchalasani
Copy link
Contributor

  • (Lance) DocChatAgent: add_content_fields
  • VectorStore.compute_from_docs adjust

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7f5d6a8) 73.98% compared to head (0bf641d) 74.18%.

Files Patch % Lines
langroid/utils/pydantic_utils.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   73.98%   74.18%   +0.19%     
==========================================
  Files          77       78       +1     
  Lines        6485     6539      +54     
==========================================
+ Hits         4798     4851      +53     
- Misses       1687     1688       +1     
Flag Coverage Δ
unittests 74.18% <98.24%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pchalasani pchalasani merged commit 7f0ecf6 into main Jan 5, 2024
4 checks passed
@pchalasani pchalasani deleted the doc-chat-content-fields branch January 5, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant