Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]: issue#9443support object type in custom tool's parameters #9822

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[fix]: issue#9443support object type in custom tool's parameters #9822

wants to merge 3 commits into from
+3 −0

Conversation

Dofine-dufei
Copy link
Contributor

@Dofine-dufei Dofine-dufei commented Oct 25, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes #9443

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 25, 2024
@crazywoola crazywoola requested a review from Yeuoly October 25, 2024 02:11
@romainpaoli
Copy link

romainpaoli commented Dec 15, 2024 •
edited
Loading

@Yeuoly it seems that this PR would fix a limitation of tools I encountered while testing dify today. Would you please give an eye to Dofine-dufei fix proposal ? Cheers.

@crazywoola
Copy link
Member

@romainpaoli Currently we are migration existing tools and model runtimes to new architecture. #11588 So we can not make changes to tool related stuffs at this moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeuoly Yeuoly Awaiting requested review from Yeuoly

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Tool's parameters doesn't support object type.
3 participants
@Dofine-dufei @romainpaoli @crazywoola