Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add analyticdb as model provider #9220

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add analyticdb as model provider #9220

wants to merge 1 commit into from
+276 −14

Conversation

lpdink
Copy link
Contributor

@lpdink lpdink commented Oct 11, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This pull request introduces support for AnalyticDB as a new model provider. Currently, AnalyticDB offers two reranking models, with plans to introduce embedding models in the future. This addition will allow customers who have purchased AnalyticDB instances to easily call these models.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

The changes were tested using manually filled credentials.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime labels Oct 11, 2024
@crazywoola
Copy link
Member

Please fix the lint and resolve the deps

@lpdink
Copy link
Contributor Author

lpdink commented Oct 12, 2024

@crazywoola Thanks, I've fixed the linting issue and the changes have passed CI.

@lpdink
Copy link
Contributor Author

lpdink commented Oct 17, 2024

@crazywoola The conflicts have been resolved. Could you please review and approve this PR?

@crazywoola
Copy link
Member

Hello, it seems to have conflicts again :( sorry for this. And you need to add tests for new providers.

@crazywoola crazywoola marked this pull request as draft October 22, 2024 13:27
@crazywoola crazywoola self-requested a review October 22, 2024 13:27
@crazywoola crazywoola self-assigned this Oct 22, 2024
@lpdink lpdink marked this pull request as ready for review October 23, 2024 06:55
@lpdink
Copy link
Contributor Author

lpdink commented Oct 23, 2024

@crazywoola Sorry for missing the test, it's been added now and conflicts have been resolved.

@lpdink lpdink force-pushed the rerank_update branch 2 times, most recently from e272003 to c34e9ff Compare October 23, 2024 08:47
@lpdink
Copy link
Contributor Author

lpdink commented Nov 18, 2024

@crazywoola
Conflicts have been resolved again.I noticed that it hasn't been reviewed in a while. Could you please take a look when you have a moment? Thank you!

@crazywoola crazywoola marked this pull request as draft December 12, 2024 05:55
@crazywoola crazywoola mentioned this pull request Dec 12, 2024
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola Awaiting requested review from crazywoola

At least 1 approving review is required to merge this pull request.

Assignees

@crazywoola crazywoola

Labels
⚙️ feat:model-runtime size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpdink @crazywoola