-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove the unused retry index field #11903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
🐞 bug
Something isn't working
labels
Dec 20, 2024
laipz8200
reviewed
Dec 20, 2024
crazywoola
previously approved these changes
Dec 20, 2024
Signed-off-by: -LAN- <laipz8200@outlook.com>
…ode_executions Signed-off-by: -LAN- <laipz8200@outlook.com>
…ata structures Signed-off-by: -LAN- <laipz8200@outlook.com>
… and graph runtime state Signed-off-by: -LAN- <laipz8200@outlook.com>
… and queue listening errors Signed-off-by: -LAN- <laipz8200@outlook.com>
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Dec 23, 2024
laipz8200
approved these changes
Dec 23, 2024
5 tasks
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Dec 24, 2024
* commit 'e88ea71aefd2adca64683ce0cca836df015d0f4f': (91 commits) chore/bump version to 0.14.2 (langgenius#12017) fix: issue Multiple Paths Between IF/ELSE Branches (langgenius#11646) Fix/refactor invoke result handling in question classifier node (langgenius#12015) fix: remove json_schema if response format is disabled. (langgenius#12014) fix: add UUID validation for tool file ID extraction (langgenius#12011) fix: add logging for missing edge mapping in StreamProcessor (langgenius#12008) Fix/add retry mechanism to billing service request handling (langgenius#12006) Fix/workflow retry log (langgenius#12013) fix: add retry feature to code node (langgenius#12005) fix: drop useless and wrong code in Account (langgenius#11961) fix: improve error handling for file retrieval in AwsS3Storage (langgenius#12002) Fix/workflow retry (langgenius#11999) feat: add RequestBodyError for invalid request body handling (langgenius#11994) fix: Introduce ArrayVariable and update iteration node to handle it (langgenius#12001) fix: remove unused credential validation logic in VectorizerProvider (langgenius#12000) feat: Warning on invite modal when mail setup is incomplete (langgenius#11809) fix: handle broader request exceptions in OAuth process (langgenius#11997) fix: Multiple Paths Between IF/ELSE Branches Invalidate Conditions (langgenius#11544) fix: retry node in iteration logs wrong (langgenius#11995) fix: remove the unused retry index field (langgenius#11903) ... # Conflicts: # web/yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The retry_index field in the node_executions table was not actually functioning, so it has been removed. Additionally, the issue with retry logs in iteration nodes has been fixed.
Fixes #11871
Fixes #11896
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods