Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToolExecutionRequest has a problem when parse argument to map #24

Closed
breezexiao opened this issue Jul 15, 2023 · 3 comments
Closed

ToolExecutionRequest has a problem when parse argument to map #24

breezexiao opened this issue Jul 15, 2023 · 3 comments

Comments

@breezexiao
Copy link

ToolExecutionRequest argumentsAsMap has a problem when parse argument to map, for example, default gson convert number to double, then cause java.lang.IllegalArgumentException: argument type mismatch when toolExecutor.execute beause my tool function parameter is integer
@langchain4j
Copy link
Owner

@breezexiao thank you for reporting! Could you please provide your tool method and the exception you are getting? Logs of execution would be very helpful as well. Thank you!

langchain4j pushed a commit that referenced this issue Jul 15, 2023
Fix for #24
e316d12
langchain4j added a commit that referenced this issue Jul 15, 2023
@langchain4j
Fix for #24 (#28)
907c1eb 
Added logic that attempts to convert Double to the type of tool (method)
parameter
@langchain4j
Copy link
Owner

@breezexiao the issue has been fixed.
Please check 0.13.0 release and let me know if you have any problems.
Thanks

@breezexiao
Copy link
Author

@breezexiao the issue has been fixed. Please check 0.13.0 release and let me know if you have any problems. Thanks

@langchain4j Cool , my problem has been solved, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@breezexiao @langchain4j