Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bedrock.py - support of other endpoint url (esp. for users of … #7592

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

Ducasse-Arthur
Copy link
Contributor

Added an endpoint_url attribute to Bedrock(LLM) class - I have access to Bedrock only via us-west-2 endpoint and needed to change the endpoint url, this could be useful to other users

@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 12, 2023 10:37am

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Jul 12, 2023
@baskaryan
Copy link
Collaborator

awesome, thanks @Ducasse-Arthur!

@baskaryan baskaryan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 12, 2023
@baskaryan baskaryan merged commit 93a84f6 into langchain-ai:master Jul 12, 2023
@Ducasse-Arthur Ducasse-Arthur deleted the patch-1 branch July 12, 2023 14:53
@Ducasse-Arthur
Copy link
Contributor Author

I would like to update the corresponding documentation page (https://python.langchain.com/docs/modules/model_io/models/llms/integrations/bedrock.html) which is now incomplete - how could I do that?

@dwaiba
Copy link
Contributor

dwaiba commented Jul 19, 2023

I would like to update the corresponding documentation page (https://python.langchain.com/docs/modules/model_io/models/llms/integrations/bedrock.html) which is now incomplete - how could I do that?

#7927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants