Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerBI updates #7143

Merged
merged 25 commits into from
Jul 6, 2023
Merged

PowerBI updates #7143

merged 25 commits into from
Jul 6, 2023

Conversation

eavanvalkenburg
Copy link
Contributor

Several updates for the PowerBI tools:

  • Handle 0 records returned by requesting redo with different filtering
  • Handle too large results by optionally tokenizing the result and comparing against a max (change in signature, non-breaking)
  • Implemented LLMChain with Chat for chat models for the tools.
  • Updates to the main prompt including tables
  • Update to Tool prompt with TOPN function
  • Split the tool prompt to allow the LLMChain with ChatPromptTemplate

Smaller fixes for stability.

For visibility: @hinthornw

eavanvalkenburg and others added 22 commits June 23, 2023 07:23
@eavanvalkenburg
catch outdated token
c986485
@eavanvalkenburg
fixed missing none check
db8d9b6
@eavanvalkenburg
small updates
0e5b7e2
@eavanvalkenburg
Merge branch 'master' of https://github.com/eavanvalkenburg/langchain
8af5465
@eavanvalkenburg
fix for 0 returned records
3e1ee13
@eavanvalkenburg
added option for token check and TOPN function
ade1840
@eavanvalkenburg
too large is handled through agent
5187412
@eavanvalkenburg
updated prompt and flow
2f72efc
@eavanvalkenburg
Merge branch 'hwchase17:master' into pbi_handle_0_and_large
364e3e3
@eavanvalkenburg
added params to toolkit
cfd82ff
@eavanvalkenburg
updated message
603c9cd
@eavanvalkenburg
slight base prompt update
86d82bd
@eavanvalkenburg
update tokenezing
ecd69b8
@eavanvalkenburg
catch forbidden from pbi
d03cf5c
@eavanvalkenburg
retun when message caught
9112131
@eavanvalkenburg
catch token error
5015044
@eavanvalkenburg
updated chat base prompt
9e797f8
@eavanvalkenburg
restructured prompt
09ccd10
@eavanvalkenburg
updated prompt and llmchain
1db7949
@eavanvalkenburg
updated validations
d29b827
@eavanvalkenburg
another validation and 0 records within chain
f956fcc
@eavanvalkenburg
Merge branch 'hwchase17:master' into pbi_handle_0_and_large
af0c742
@vercel
Copy link

vercel bot commented Jul 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 6, 2023 6:32am

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Jul 4, 2023
hwchase17
hwchase17 reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to largely trust you here, just one nit

langchain/tools/powerbi/tool.py Outdated Show resolved Hide resolved
@hwchase17 hwchase17 merged commit ae5aa49 into langchain-ai:master Jul 6, 2023
@eavanvalkenburg eavanvalkenburg deleted the pbi_handle_0_and_large branch July 6, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 left review comments

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eavanvalkenburg @hwchase17