Fix missing chain classname in StdOutCallbackHandler.on_chain_start #6124
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was curious that there seems to be some overlap with the StdOutCallbackHandler and ConsoleCallbackHandler tracer and was curious about the design direction. Is the tracing handler intended to eventually replace this? |
idoru
force-pushed
the
fix-verbose-stdout-error
branch
from
5c72d17 to
b25f26b
Compare
idoru
changed the title
vowelparrot
reviewed
Jun 18, 2023
|
The console handler provides even more information than the stdout callback handler and structures it more according to the trace tree than an event log |
Co-authored-by: Zander Chase <130414180+vowelparrot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vowelparrot
approved these changes
Jun 23, 2023
This was referenced Jul 13, 2023
baskaryan
pushed a commit
that referenced
this pull request
Jul 14, 2023
Fix for Serializable class to include name, used in FileCallbackHandler as same issue #7524 Description: Fixes the Serializable class to include 'name' attribute (class_name) in the dict created, This is used in Callbacks, specifically the StdOutCallbackHandler, FileCallbackHandler. Issue: As described in issue #7524 Dependencies: None Tag maintainer: SInce this is related to the callback module, tagging @agola11 @idoru Comments: Glad to see issue #7524 fixed in pull #6124, but you forget to change the same place in FileCallbackHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieves the name of the class from new location as of commit 18af149
Before submitting
Who can review?
Tag maintainers/contributors who might be interested:
Tracing / Callbacks