langchain-mistralai: add missing _combine_llm_outputs implementation in ChatMistralAI #18603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
|
Hey @efriis, do you have time to look this PR? Would be great to fix MistralAI implemention. Thanks! |
baskaryan
approved these changes
Mar 29, 2024
dosubot
bot
added
the
lgtm
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…ChatMistralAI (langchain-ai#18603) # Description Implementing `_combine_llm_outputs` to `ChatMistralAI` to override the default implementation in `BaseChatModel` returning `{}`. The implementation is inspired by the one in `ChatOpenAI` from package `langchain-openai`. # Issue None # Dependencies None # Twitter handle None --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…ChatMistralAI (#18603) # Description Implementing `_combine_llm_outputs` to `ChatMistralAI` to override the default implementation in `BaseChatModel` returning `{}`. The implementation is inspired by the one in `ChatOpenAI` from package `langchain-openai`. # Issue None # Dependencies None # Twitter handle None --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing
_combine_llm_outputstoChatMistralAIto override the default implementation inBaseChatModelreturning{}. The implementation is inspired by the one inChatOpenAIfrom packagelangchain-openai.Issue
None
Dependencies
None
Twitter handle
None