Simplify ensemble retriever #14427
Simplify ensemble retriever #14427
Conversation
ahmed-moubtahij
commented
Dec 8, 2023
•
ahmed-moubtahij
commented
- Description: code simplification to improve readability and remove unnecessary memory allocations.
- Tag maintainer: @baskaryan, @eyurtsev, @hwchase17.
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
Ɑ: models
…em/langchain into simplify-ensemble_retriever
| @@ -38,6 +38,14 @@ def wrapper(*args: Any, **kwargs: Any) -> Any: | |||
|
|
|||
| return decorator | |||
|
|
|||
| T = TypeVar('T') | |||
| H = TypeVar('H', bound=Hashable) | |||
| def unique_by_key(iterable: Iterable[T], key: Callable[[T], H]) -> Iterator[T]: | |||
There was a problem hiding this comment.
maybe just worth being local to ensemble retriever until we use in multiple places?
There was a problem hiding this comment.
@hwchase17 Any more changes you'd like to see?
There was a problem hiding this comment.
@hwchase17 I apparently needed to run make lint at the langchain_core level as well (root didn't detect the lint fails on CI), it should be ok now.
…em/langchain into simplify-ensemble_retriever
|
@hwchase17 @baskaryan Looks good to go? |
|
make format and make lint pass locally but fail on CI (
I don't know how to fix this. |
dosubot
bot
added
size:L
|
Deployment failed with the following error: |
dosubot
bot
added
size:M
- **Description:** code simplification to improve readability and remove unnecessary memory allocations. - **Tag maintainer**: @baskaryan, @eyurtsev, @hwchase17. --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
- **Description:** code simplification to improve readability and remove unnecessary memory allocations. - **Tag maintainer**: @baskaryan, @eyurtsev, @hwchase17. --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
