This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Ini scanner mode #10
Merged
Ini scanner mode #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsanyi
force-pushed
the
ini-scanner-mode
branch
from
770a616 to
c08a2b4
Compare
Ocramius
suggested changes
Sep 9, 2020
src/Reader/Ini.php
Outdated
| * @param bool $typedMode | ||
| * @return $this | ||
| */ | ||
| public function setTypedMode($typedMode) |
There was a problem hiding this comment.
This should just accept bool as an input (no cast in method)
src/Reader/Ini.php
Outdated
| * @see https://www.php.net/parse_ini_file | ||
| * @return bool | ||
| */ | ||
| public function getTypedMode() |
src/Reader/Ini.php
Outdated
| * @see https://www.php.net/parse_ini_file | ||
| * @return int | ||
| */ | ||
| public function getScannerMode() |
|
I added the type hinting you requested.
I agree - I was thinking I should add constructor support for all 3 options as a follow-up PR. |
jcsanyi
force-pushed
the
ini-scanner-mode
branch
from
eb278ba to
fc3c37a
Compare
Signed-off-by: Jonathan Csanyi <jdc@csanyi.ca>
Signed-off-by: Jonathan Csanyi <jdc@csanyi.ca>
weierophinney
force-pushed
the
ini-scanner-mode
branch
from
fc3c37a to
3d9852b
Compare
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- Removes annotations where typehints exist - Use `self`, not class name as a return type - Indent here/nowdocs (available since PHP 7.3) Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
typedModeflag to the INI Reader to support the built-inINI_SCANNER_TYPEDflag onparse_ini_file().This allows integer, boolean, and null values to be returned as the appropriate types, rather than all being returned as strings.