Return error code with RuntimeException. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Ocramius
requested changes
Feb 18, 2021
|
I'll add GHA in a PR this weekend. I'll try to rebase this PR afterwards so we can verify the test results here. 👍🏼 |
This brings parity with other storage adapters that already include the error code in exceptions. Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
1.1.x-exception-code
branch
from
6ed5716 to
03ff1ef
Compare
|
Took me a bit but I've added GHA now, added a unit test for your changes and made the tests pass. 👍🏼 |
boesing
approved these changes
Apr 24, 2021
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
1.1.x-exception-code
branch
from
94f3641 to
6cbf0a9
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
|
@EreMaijala For integrity, I've passed the result code to the other |
|
@boesing Thanks, I appreciate your extra work and attention to detail. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings parity with other storage adapters that already include the error code in exceptions.
Signed-off-by: Ere Maijala ere.maijala@helsinki.fi