Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for Renovate with reusable workflows #21

Merged
merged 5 commits into from
Mar 25, 2022
Merged

Prepare for Renovate with reusable workflows #21

merged 5 commits into from
Mar 25, 2022

Conversation

ghostwriter
Copy link
Contributor

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

@ghostwriter
Configure minimum supported PHP version
6486ecf 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update to reusable continuous-integration workflow
b91f223 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update to reusable automatic-releases workflow
37fbeae 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update composer.lock
ab4716e 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Ocramius
Ocramius requested changes Feb 24, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI to be fixed before considering a merge

@Ocramius Ocramius added this to the 2.1.0 milestone Mar 23, 2022
@Ocramius Ocramius requested a review from boesing March 23, 2022 09:40
@boesing
Copy link
Member

boesing commented Mar 23, 2022

How to add services to the CI pipeline?
Same as in the other components which do need docker services like memcached, redis, and stuff, this is not mergable.
If we do not have a solution for this right now, I'll keep this open until we have

boesing
boesing requested changes Mar 23, 2022
View reviewed changes
.github/workflows/continuous-integration.yml Outdated
needs: [matrix]
runs-on: ${{ matrix.operatingSystem }}
services:
memcached:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be somehow restored or tests will always fail

@Ocramius
Copy link
Member

For having services again, we need to go back, and avoid the reusable workflow here.

@ghostwriter
Revert "Update to reusable continuous-integration workflow"
021f8e5 
This reverts commit b91f223.

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter requested a review from Ocramius March 23, 2022 16:46
Ocramius
Ocramius requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, 8.1 lowest and 8.1 latest seem to fail 🤔

@ghostwriter
Copy link
Contributor Author

TypeError thrown, possibly false positives.

TypeError: Memcached::setMulti(): Argument #2 ($expiration) must be of type int, int given

@Ocramius Ocramius requested a review from boesing March 24, 2022 01:21
boesing
boesing approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging for now, tests are also failing in target branch and this looks good from what I can see.

@boesing boesing merged commit e67cfcb into laminas:2.1.x Mar 25, 2022
@ghostwriter ghostwriter deleted the feature/renovate branch March 26, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius requested changes

@boesing boesing boesing approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ghostwriter @boesing @Ocramius