app: Port to GTK4 + libadwaita #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now everything is split, I think PRs after this one should be merged first and then, if everything looks good here, I'll rebase to fix the conflicts. The remaining issues aren't blockers. Style is being applied with css-classes property anyways and TreeView critical is an issue on GTK side. Testing this branch doesn't seem to bring any regressions compared to the stable version, at least, that I've noticed. |
|
Thanks, i have started to play with it locally and it seems great, I'll finish the review tomorrow and help for the failing tests |
|
Thanks! Tests are actually passing, I should have deleted the words not and yet instead of crossing them out 😅 |
Can be removed when GNOME SDK and Runtime update to version 43.
|
Rebased on top of master to fix conflicts. |
lachhebo
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Commits are on top of the PRs I opened previously). I'll try to split this PR into smaller ones if they aren't strictly required for the port.The purpose of this PR is to do a 1:1 port; without changing the interface layout, at least not in this one 😉
Flatpak CI should output a working build in my fork's branch.
Help to complete the port is always welcome 😄
Progress
Buttons:
(works installing it as a system package, but not as a Flatpak)(works installing it as a system package, but not as a Flatpak)Widgets:
UI:
</style>tag instead ofcss-classespropertyIt doesn't currently work and there seems to be no reason why it shouldn't.
Tests are passing now!