Correct handling of linear model fitting failure #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we look at the determinant of the matrix of coefficients, not just whether all the individual values are zero. Also the intercept is now zeroed out which fixes the single tile placed far from the rest (even though this was a sign of complete EdgeAligner failure). A warning is emitted in the failure case to alert the user of the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we look at the determinant of the matrix of coefficients, not just whether all the individual values are zero. Also the intercept is now zeroed out which fixes the single tile placed far from the rest (even though this was a sign of complete EdgeAligner failure). A warning is emitted in the failure case to alert the user of the problem.