Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:frontend upload convertdata #4382

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix:frontend upload convertdata #4382

merged 1 commit into from
Dec 7, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Dec 6, 2023

🤖[deprecated] Generated by Copilot at 001477c

Summary

🐛🚀📝

This pull request simplifies the defaultUrl for the uploadConvertData function and adds error handling for its calls in various components. It also removes unnecessary console.log statements and fixes some minor issues with the CodeBlock and Tutorial components.

uploadConvertData
catch errors from the API
autumn of debugging

Walkthrough

  • Simplified the defaultUrl for the uploadConvertData function to always use https://sealos.run/ and improved the error message for missing bd_vid in frontend/desktop/src/api/platform.ts and service/license/src/api/system.ts (link, link)
  • Wrapped the uploadConvertData function calls with catch blocks to handle errors from the API requests in various components and pages (link, link, link, link, link)
  • Removed unused import statements and console.log statements from the uploadData API handlers in frontend/desktop/src/pages/api/platform/uploadData.ts and service/license/src/pages/api/platform/uploadData.ts (link, link, link, link)
  • Changed the command prompt symbol from $ to # in the CodeBlock component in service/license/src/components/CodeBlock/index.tsx to indicate root or sudo privileges (link)
  • Corrected the install command in the Tutorial component in service/license/src/pages/cluster/components/Tutorial.tsx to use scripts/install.sh instead of install.sh (link)

Signed-off-by: jingyang <3161362058@qq.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1081
✅ Successful 395
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 685
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2255850) 65.45% compared to head (001477c) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4382   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c121914yu c121914yu merged commit 17fe9c2 into labring:main Dec 7, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants