Update gateway usage #4264

zzjin · 2023-11-06T14:59:43Z

Update NGINX ingress annotations.
Remove usage references to APISIX.
Add higress anntations.

`🤖 Generated by Copilot at 523a9f5`

Summary

🚫🚀🐛

Removed APISIX support from the Adminer and Terminal controllers and their related resources. Simplified the ingress configuration and code for these controllers and the registry service. Updated the documentation and CRDs accordingly.

Sing, O Muse, of the mighty pull request
That purged the apisix option from the code
And made the nginx ingress controller reign
Over the Adminer and Terminal modes

Walkthrough

Remove support for APISIX ingress controller and use only NGINX ingress controller for adminer and terminal services (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
Add support for higress annotations to control the response headers for security purposes in the createNginxIngress function in controllers/db/adminer/controllers/ingress.go (link, link, link)
Change the path field from /()(.*) to / in the ingress.yaml sections in docs/4.0/docs/quick-start/app-deployments/use-terminal.md and docs/4.0/i18n/zh-Hans/quick-start/app-deployments/use-terminal.md to fix a redirection issue with the terminal service (link, link)
Remove the rewrite-target annotation from the ingress.yaml files in controllers/db/adminer/controllers/ingress.go, controllers/terminal/controllers/ingress.go, and deploy/registry/manifests/ingress.yaml, as it is not needed for the adminer, terminal, and registry services ( link, link)
Remove the configuration-snippet and AuthType constants from the ingress.go files in controllers/db/adminer/controllers/ingress.go and controllers/terminal/controllers/ingress.go, as they are not used by the adminer and terminal controllers (link, link, link, link)
Remove the time package import from the ingress.go files in controllers/db/adminer/controllers/ingress.go and controllers/terminal/controllers/ingress.go, as it is no longer needed (link, link)
Change the defaultNginxConfigurationSnippet to use fmt.Sprintf instead of string concatenation in controllers/db/adminer/controllers/ingress.go for readability and maintainability (link)
Move the constants for the response headers and the default configuration domain to the top of the ingress.go file in controllers/db/adminer/controllers/ingress.go (link)

sealos-ci-robot · 2023-11-06T15:00:09Z

🤖 Generated by lychee action

Summary

Status	Count
🔍 Total	993
✅ Successful	321
⏳ Timeouts	0
🔀 Redirected	0
👻 Excluded	671
❓ Unknown	0
🚫 Errors	0

Full action output

Full Github Actions output

sweep-ai · 2023-11-06T15:00:47Z

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.

codecov · 2023-11-06T15:07:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc0c3f6) 65.45% compared to head (523a9f5) 65.45%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4264   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sealos-ci-robot · 2023-11-08T15:51:28Z

📘 Preview documentation website

👀 Visit Preview

pull-request-size · 2023-11-10T12:41:02Z

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

1. Update NGINX ingress annotations. 2. Remove usage references to APISIX. Signed-off-by: zzjin <tczzjin@gmail.com>

Moved from ingress gateway annotation to backend server decide. Signed-off-by: zzjin <tczzjin@gmail.com>

Signed-off-by: zzjin <tczzjin@gmail.com>

Remove static-cdn image. Remove adminer zalando support. Signed-off-by: zzjin <tczzjin@gmail.com>

Signed-off-by: zzjin <tczzjin@gmail.com>

lingdie · 2023-11-17T16:24:51Z

applaunchpad等ingress变了，sealos cloud部署脚本中是不是需要使用higress作为网关？有影响吗？

sealos-ci-robot · 2023-11-17T16:25:05Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Applaunchpad and other ingress have changed. Is it necessary to use higress as the gateway in the sealos cloud deployment script? Is there any impact?

zzjin · 2023-11-17T16:47:37Z

applaunchpad等ingress变了，sealos cloud部署脚本中是不是需要使用higress作为网关？有影响吗？

不需要改应用代码,安装 higress的时候会改写参数,让 higress 监听所有 class=nginx 的资源,但是需要 run 一下 higress 的集群镜像(todo)

sealos-ci-robot · 2023-11-17T16:47:52Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Ingress such as applaunchpad has changed. Is it necessary to use higress as the gateway in the sealos cloud deployment script? Is there any impact?

No, when installing higress, the parameters will be rewritten to allow higress to monitor all resources with class=nginx

pull-request-size bot added the size/XL label Nov 6, 2023

sealos-ci-robot added area/cloud area/ci area/frontend area/api labels Nov 6, 2023

zzjin deployed to Preview November 8, 2023 15:34 — with GitHub Actions View deployment

sealos-ci-robot added the kind/documentation label Nov 8, 2023

zzjin force-pushed the dev_gateway branch from 9ec37ab to 8a60fbb Compare November 8, 2023 15:41

zzjin added this to the v5.0 milestone Nov 8, 2023

zzjin deployed to Preview November 8, 2023 15:51 — with GitHub Actions View deployment

sealos-ci-robot added the area/lifecycle-management label Nov 8, 2023

zzjin deployed to Preview November 9, 2023 08:57 — with GitHub Actions View deployment

zzjin force-pushed the dev_gateway branch from 15f45b6 to 79c5701 Compare November 10, 2023 12:40

zzjin deployed to Preview November 10, 2023 12:40 — with GitHub Actions View deployment

pull-request-size bot added size/XXL and removed size/XL labels Nov 10, 2023

zzjin force-pushed the dev_gateway branch from 79c5701 to b528a9c Compare November 14, 2023 14:50

zzjin deployed to Preview November 14, 2023 14:51 — with GitHub Actions View deployment

zzjin added 5 commits November 15, 2023 21:42

Update gateway usage

abf1c2e

1. Update NGINX ingress annotations. 2. Remove usage references to APISIX. Signed-off-by: zzjin <tczzjin@gmail.com>

Remove all gzip relative annotations.

6c2b20d

Moved from ingress gateway annotation to backend server decide. Signed-off-by: zzjin <tczzjin@gmail.com>

Fix main.go conflict.

3ba3dfe

Signed-off-by: zzjin <tczzjin@gmail.com>

Rewrite all rewrite-target annotation

a309c9d

Remove static-cdn image. Remove adminer zalando support. Signed-off-by: zzjin <tczzjin@gmail.com>

update ingress,setup higress annotations.

523a9f5

Signed-off-by: zzjin <tczzjin@gmail.com>

zzjin force-pushed the dev_gateway branch from b528a9c to 523a9f5 Compare November 15, 2023 13:42

zzjin deployed to Preview November 15, 2023 13:43 — with GitHub Actions View deployment

zzjin marked this pull request as ready for review November 16, 2023 14:50

lingdie approved these changes Nov 17, 2023

View reviewed changes

zzjin merged commit 9095a2e into labring:main Nov 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gateway usage #4264

Update gateway usage #4264

zzjin commented Nov 6, 2023 •

edited by ghost

Loading

sealos-ci-robot commented Nov 6, 2023 •

edited

Loading

sweep-ai bot commented Nov 6, 2023

codecov bot commented Nov 6, 2023 •

edited

Loading

sealos-ci-robot commented Nov 8, 2023 •

edited

Loading

pull-request-size bot commented Nov 10, 2023

lingdie commented Nov 17, 2023

sealos-ci-robot commented Nov 17, 2023

zzjin commented Nov 17, 2023 •

edited

Loading

sealos-ci-robot commented Nov 17, 2023

Update gateway usage #4264

Update gateway usage #4264

Conversation

zzjin commented Nov 6, 2023 • edited by ghost Loading

🤖 Generated by Copilot at 523a9f5

Summary

Walkthrough

sealos-ci-robot commented Nov 6, 2023 • edited Loading

🤖 Generated by lychee action

Summary

Full action output

sweep-ai bot commented Nov 6, 2023

Apply Sweep Rules to your PR?

codecov bot commented Nov 6, 2023 • edited Loading

Codecov Report

sealos-ci-robot commented Nov 8, 2023 • edited Loading

📘 Preview documentation website

pull-request-size bot commented Nov 10, 2023

Whoa! Easy there, Partner!

lingdie commented Nov 17, 2023

sealos-ci-robot commented Nov 17, 2023

zzjin commented Nov 17, 2023 • edited Loading

sealos-ci-robot commented Nov 17, 2023

zzjin commented Nov 6, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at 523a9f5`

sealos-ci-robot commented Nov 6, 2023 •

edited

Loading

codecov bot commented Nov 6, 2023 •

edited

Loading

sealos-ci-robot commented Nov 8, 2023 •

edited

Loading

zzjin commented Nov 17, 2023 •

edited

Loading