Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Automated CherryPick Update for release-v4.4 #4126

Merged
merged 1 commit into from
Oct 20, 2023
Merged

docs: Automated CherryPick Update for release-v4.4 #4126

merged 1 commit into from
Oct 20, 2023

Conversation

sealos-ci-robot
Copy link
Member

@sealos-ci-robot sealos-ci-robot commented Oct 20, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at fac3990

Summary

⚙️⬆️📝

Update KubeadmConfig to support multiple kubeadm API versions and default to v1beta3. Improve code documentation in pkg/runtime/kubernetes/types/kubeadm_config.go.

Sing, O Muse, of the mighty pull request
That changed the KubeadmConfig struct and its methods
To handle different versions of kubeadm, the tool of gods
And convert them as needed with skill and wisdom.

Walkthrough

  • Modify GetComponents method to use ToConvertedKubeadmConfig for conversion (link)
  • Set default kubeadm API version to v1beta3 for empty Version field (link)
  • Add comment to explain default case for unknown kubeadm versions (link)

Automated changes by create-pull-request GitHub action

@fengxsong
fix: return converted component configs (#4121)
fac3990 
Signed-off-by: fengxsong <fengxsong@outlook.com>
@sweep-ai
Copy link

sweep-ai bot commented Oct 20, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@cuisongliu cuisongliu merged commit fa88777 into release-v4.4 Oct 20, 2023
@cuisongliu cuisongliu deleted the cherry-pick-release-v4.4-4121 branch October 20, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/lifecycle-management area/runtime size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sealos-ci-robot @cuisongliu @fengxsong