Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): init cli #488

Merged
merged 1 commit into from
Dec 24, 2022
Merged

feat(cli): init cli #488

merged 1 commit into from
Dec 24, 2022

Conversation

skyoct
Copy link
Contributor

@skyoct skyoct commented Dec 6, 2022

初始化cli项目
实现应用列表&初始化应用

@skyoct skyoct requested a review from maslow December 6, 2022 13:49
(error) => {
// 错误抛到业务代码
error.data = {}
error.data.msg = '服务器异常,请联系管理员!'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码中的中文,还是在写的时候 统一 去除掉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

cli/src/templates/application.ts Show resolved Hide resolved
"url": "https://github.com/labring/laf/issues"
},
"devDependencies": {
"@types/cli-table2": "^0.2.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/cli-table: '^0.3.1' ?

Comment on lines +2 to +3
import { getRemoteServer } from './token'
import { getAccessToken } from './token'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combine into one line

Comment on lines +4 to +8
return 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiI2MzhkZDdhNTBlZTVjMGViNjk2NWU2NzIiLCJpYXQiOjE2NzAzMTE2ODksImV4cCI6MTY3MDkxNjQ4OX0.2UtpV0WC5kvtoPynvhXCSnrh9vadKQ7crLBMSxnI3A8'
}

export function getRemoteServer(): string {
return 'http://localhost:3000'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些是不是应该弄到配置文件?

@maslow maslow merged commit 90b177f into labring:main Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants