Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Upgrade kyma from 2.9.3 to 2.11.4 #3628

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Upgrade kyma from 2.9.3 to 2.11.4 #3628

merged 2 commits into from
Feb 2, 2024

Conversation

nyordanoff
Copy link
Contributor

@nyordanoff nyordanoff commented Feb 1, 2024

Description
This PR upgrades the Kyma version from 2.9.3 to 2.11.4

Changes proposed in this pull request:

  • bumped kyma and kyma cli versions
  • as of version 1.16 of Istio (which comes with this Kyma upgrade), the sidecar.istio.io/inject annotation was deprecated in favour of the sidecar.istio.io/inject label
  • updated docs

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@nyordanoff nyordanoff requested review from a team as code owners February 1, 2024 08:12
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/missing-docs-review Indicates that a PR should not merge beacuse it has missing documentation review. cla: yes Indicates the PR's author has signed the CLA. 🦖 team-raptor Team Raptor Label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2024
@kyma-bot
Copy link

kyma-bot commented Feb 1, 2024

@nyordanoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark d80bcad link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nyordanoff
Copy link
Contributor Author

Тhe benchmark job is expected to fail because firstly it installs compass from main branch (that creates a certs-setup-job Job) and then when compass is reinstalled from the branch, there is a change that adds new label to this Job’s pod (the job already exists and a patch is performed but the labels field is immutable)

@nyordanoff nyordanoff changed the title [WIP] Upgrade kyma to 2.11 Upgrade kyma from 2.9.3 to 2.11.4 Feb 2, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2024
@nyordanoff
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@nyordanoff nyordanoff added the 👋 request review Review required label Feb 2, 2024
@@ -46,7 +46,7 @@ Therefore, `serviceAccountTokenJWKS` and `serviceAccountTokenIssuer` need to be

> **NOTE:** During the installation of Compass, the installed Kyma version (as a basis to Compass) must match to the one in the [`KYMA_VERSION`](../../installation/resources/KYMA_VERSION) file in the specific Compass commit.

If custom domains and certificates are needed, see the [Set up your custom domain TLS certificate](https://github.com/kyma-project/kyma/blob/2.9.3/docs/03-tutorials/00-security/sec-01-tls-certificates-security.md) document in the Kyma installation guide, as well as the resources in the [Certificate Management](#certificate-management) section in this document.
If custom domains and certificates are needed, see the [Set up your custom domain TLS certificate](https://github.com/kyma-project/kyma/blob/2.11.2/docs/03-tutorials/00-security/sec-01-tls-certificates-security.md) document in the Kyma installation guide, as well as the resources in the [Certificate Management](#certificate-management) section in this document.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it 2.11.4? Same for the other docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, 2.11.2 is the Kyma CLI version and it seems that I misconfigured them in the docs. Will update it, thanks.

cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
labels:
app: {{ .Chart.Name }}-tenant-fetcher-tests-app
sidecar.istio.io/inject: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving Atlas a heads-up on this (annotation replaced by label) could be a good idea

Copy link
Contributor Author

@nyordanoff nyordanoff Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We label the whole atom namespace in our pipelines:
kubectl label ns atom istio-injection=enabled --overwrite

Also, there aren't any pods in that namespace to have the mentioned annotation:
kubectl get po -o=jsonpath='{.items[?(@.metadata.annotations.sidecar\.istio\.io/inject)].metadata.name}' -n atom

I can inform them not to add it in the future but I guess they won't do it anyways because the namespace labelling does that out of the box.

Copy link
Contributor

@ekaterina-mitova ekaterina-mitova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kyma-bot kyma-bot added lgtm Looks good to me! and removed do-not-merge/missing-docs-review Indicates that a PR should not merge beacuse it has missing documentation review. labels Feb 2, 2024
@kyma-bot
Copy link

kyma-bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekaterina-mitova, ognyvrac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@nyordanoff
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@kyma-bot kyma-bot merged commit 0d71ac5 into main Feb 2, 2024
5 of 6 checks passed
@nyordanoff nyordanoff deleted the upgrade-to-kyma-2-11 branch February 2, 2024 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label 👋 request review Review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants