-
Notifications
You must be signed in to change notification settings - Fork 82
Conversation
@nyordanoff: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Тhe benchmark job is expected to fail because firstly it installs compass from main branch (that creates a certs-setup-job Job) and then when compass is reinstalled from the branch, there is a change that adds new label to this Job’s pod (the job already exists and a patch is performed but the labels field is immutable) |
/hold |
docs/compass/04-01-installation.md
Outdated
@@ -46,7 +46,7 @@ Therefore, `serviceAccountTokenJWKS` and `serviceAccountTokenIssuer` need to be | |||
|
|||
> **NOTE:** During the installation of Compass, the installed Kyma version (as a basis to Compass) must match to the one in the [`KYMA_VERSION`](../../installation/resources/KYMA_VERSION) file in the specific Compass commit. | |||
|
|||
If custom domains and certificates are needed, see the [Set up your custom domain TLS certificate](https://github.com/kyma-project/kyma/blob/2.9.3/docs/03-tutorials/00-security/sec-01-tls-certificates-security.md) document in the Kyma installation guide, as well as the resources in the [Certificate Management](#certificate-management) section in this document. | |||
If custom domains and certificates are needed, see the [Set up your custom domain TLS certificate](https://github.com/kyma-project/kyma/blob/2.11.2/docs/03-tutorials/00-security/sec-01-tls-certificates-security.md) document in the Kyma installation guide, as well as the resources in the [Certificate Management](#certificate-management) section in this document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it 2.11.4
? Same for the other docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, 2.11.2
is the Kyma CLI version and it seems that I misconfigured them in the docs. Will update it, thanks.
cluster-autoscaler.kubernetes.io/safe-to-evict: "false" | ||
labels: | ||
app: {{ .Chart.Name }}-tenant-fetcher-tests-app | ||
sidecar.istio.io/inject: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving Atlas a heads-up on this (annotation replaced by label) could be a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We label the whole atom
namespace in our pipelines:
kubectl label ns atom istio-injection=enabled --overwrite
Also, there aren't any pods in that namespace to have the mentioned annotation:
kubectl get po -o=jsonpath='{.items[?(@.metadata.annotations.sidecar\.istio\.io/inject)].metadata.name}' -n atom
I can inform them not to add it in the future but I guess they won't do it anyways because the namespace labelling does that out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekaterina-mitova, ognyvrac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Description
This PR upgrades the Kyma version from 2.9.3 to 2.11.4
Changes proposed in this pull request:
sidecar.istio.io/inject
annotation was deprecated in favour of thesidecar.istio.io/inject
labelRelated issue(s)
Pull Request status
chart/compass/values.yaml
is updated