Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Additional Unit test for missed branch #2765

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Additional Unit test for missed branch #2765

merged 2 commits into from
Nov 25, 2022

Conversation

dzahariev
Copy link
Member

@dzahariev dzahariev commented Nov 25, 2022 •
edited
Loading

Description
Changes proposed in this pull request:

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@dzahariev dzahariev requested review from a team as code owners November 25, 2022 08:52
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2022
@dragobt dragobt self-assigned this Nov 25, 2022
@dzahariev dzahariev added the 👋 request review Review required label Nov 25, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 25, 2022
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dragobt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@kyma-bot
Copy link

@dzahariev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 2ce3071 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 3ac7c61 into main Nov 25, 2022
@dzahariev dzahariev deleted the ADDTESTFORBRANCH branch November 25, 2022 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dragobt dragobt dragobt approved these changes

@NickyMateev NickyMateev Awaiting requested review from NickyMateev

@PetarTodorovv PetarTodorovv Awaiting requested review from PetarTodorovv

Assignees

@dragobt dragobt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files. 👋 request review Review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzahariev @kyma-bot @dragobt