Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Remove/Replace usage of deprecated go library #2711

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Remove/Replace usage of deprecated go library #2711

merged 7 commits into from
Nov 17, 2022

Conversation

PetarTodorovv
Copy link
Collaborator

@PetarTodorovv PetarTodorovv commented Oct 27, 2022 •
edited
Loading

Description
Our go linter is complaining about the usage of a deprecated package.

Changes proposed in this pull request:

  • Remove usage of deprecated ioutil go package and replace it with the new one - io/os

Pull Request status

  • Implementation
  • Unit tests
  • [N/A] Integration tests
  • chart/compass/values.yaml is updated
  • [N/A] Mocks are regenerated, using the automated script

@PetarTodorovv PetarTodorovv added 👋 request review Review required do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 27, 2022
@PetarTodorovv PetarTodorovv requested a review from a team as a code owner October 27, 2022 12:00
@PetarTodorovv PetarTodorovv self-assigned this Oct 27, 2022
@PetarTodorovv PetarTodorovv requested review from a team as code owners October 27, 2022 12:00
@kyma-bot kyma-bot added 🐉 team-dragon Team Dragon Label 🦅 team-falcon Team Falcon Label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2022
@PetarTodorovv
Copy link
Collaborator Author

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 28, 2022
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 2, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 3, 2022
@PetarTodorovv PetarTodorovv removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2022
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 17, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 17, 2022
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desislavaa, dzahariev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
@kyma-bot
Copy link

@PetarTodorovv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-compass-pjtester a7564fd link true /test pull-compass-pjtester
pre-main-compass-gke-benchmark 3a1be8e link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 9523abe into main Nov 17, 2022
@PetarTodorovv PetarTodorovv deleted the go-old-package branch November 17, 2022 13:28
@PetarTodorovv PetarTodorovv removed the 👋 request review Review required label Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desislavaa desislavaa desislavaa approved these changes

@dzahariev dzahariev dzahariev approved these changes

@alextargov alextargov Awaiting requested review from alextargov

@dragobt dragobt Awaiting requested review from dragobt

Assignees

@dzahariev dzahariev

@desislavaa desislavaa

@PetarTodorovv PetarTodorovv

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. 🐉 team-dragon Team Dragon Label 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PetarTodorovv @kyma-bot @dzahariev @desislavaa