This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Support IDPs other that Dex #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasish
requested review from
kwiatekus,
dariadomagala-sap,
akucharska,
Wawrzyn321,
a team,
PK85,
dbadura,
akgalwas,
janmedrek,
Szymongib,
franpog859,
Maladie,
piotrmiskiewicz,
ksputo,
jasiu001 and
koala7659
as code owners
kyma-bot
added
the
size/L
|
/hold |
kyma-bot
added
the
do-not-merge/hold
alextargov
reviewed
Feb 18, 2022
krasish
requested review from
Peteva,
ekaterina-mitova and
nkanchev
as code owners
review text
nkanchev
previously approved these changes
Mar 11, 2022
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/test pre-compass-tests |
|
/retest |
|
/test pre-compass-tests |
|
/retest |
|
/test pre-compass-components-director |
|
@krasish: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
nkanchev
approved these changes
Mar 15, 2022
alextargov
approved these changes
Mar 15, 2022
|
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the removal of the dex component was planned, the first step in that direction is to support other Identity Providers for the OIDC flows used in the compass UI. This PR prepares compass for working with external IDPs and makes needed chart adaptations for the relevant changes in the Compass Console.
Changes proposed in this pull request:
Pull Request status
chart/compass/values.yamlis updated