Communication Protocol Refactoring #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement functionality for Synchronous TCP connection (same as existing async) - Implement flexible config->connection flow, allows adding different connection types (like USB)
can easily edit it now in notepad
Unlike pget, we don't care about unused lines trashing up a git diff cuz these serialized settings aren't a part of the git repo. makes it ez to just change protocoltype 0->1 for USB without needing GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in the ability to select USB vs WiFi (usb-botbase vs sys-botbase sysmodules) as the communication protocol. The main automation still uses async logic, so the USB logic uses a Task wrapper around each send/receive interaction.
Information on how to use USB instead of WiFi will be on the wiki shortly after this PR is merged. Tutorial will be sourced from Koi's fork.