Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve slack message information on query request #262

Open
riupie opened this issue Dec 6, 2024 · 1 comment
Open

Improve slack message information on query request #262

riupie opened this issue Dec 6, 2024 · 1 comment

Comments

@riupie
Copy link

riupie commented Dec 6, 2024

It would be nice if the Slack message also included the query that will be executed and maybe mention the slack user/group who will review? We can bind the slack id on profile.
image

@Askir
Copy link
Member

Askir commented Dec 19, 2024

Hey riuple,
thanks for the feedback. I thought about including the request but decided against it since this can contain sensitive information. If anything I could make this configurable but it seems a bit niche honestly.

Regarding the slack id. Yes I'd love to allow people to connect their accounts more closely. This would potentially also allow checking if a specific user has access to the connection and therefore should be allowed to see the query, this would then even allow approving and denying requests straight out of slack. It's a bit more effort to set this up though so I have to delay that a bit for now. Happy about any contributions though if you happen to have the time to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants