Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RJOutputWriter #4692

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Refactor RJOutputWriter #4692

merged 2 commits into from
Jan 9, 2025

Conversation

andyfengHKU
Copy link
Contributor

Description

Remove unnecessary PathLength frontier in PathOutput.

Remove SPOutput to SPDestinationOutput (because it's used only when outputting destinations).

Remove ad-hoc function in PathMultiplicities.

Fixes # (issue)

Contributor agreement

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Benchmark Result

Master commit hash: 2e07232500904b61b2ead641982e717e6c3469cb
Branch commit hash: 78f2d3d4d6941184fd0088fc426e974f89d8d7b8

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 656.96 656.13 0.83 (0.13%)
aggregation q28 12167.73 12013.56 154.17 (1.28%)
filter q14 133.00 129.19 3.81 (2.95%)
filter q15 130.71 131.96 -1.25 (-0.95%)
filter q16 306.50 313.12 -6.62 (-2.11%)
filter q17 457.60 457.78 -0.18 (-0.04%)
filter q18 1997.87 2004.97 -7.10 (-0.35%)
filter zonemap-node 90.81 90.92 -0.11 (-0.12%)
filter zonemap-node-lhs-cast 92.77 91.10 1.66 (1.83%)
filter zonemap-node-null 86.76 86.88 -0.13 (-0.15%)
filter zonemap-rel 5756.34 5773.69 -17.35 (-0.30%)
fixed_size_expr_evaluator q07 584.46 572.91 11.55 (2.02%)
fixed_size_expr_evaluator q08 823.73 819.23 4.50 (0.55%)
fixed_size_expr_evaluator q09 819.34 802.63 16.72 (2.08%)
fixed_size_expr_evaluator q10 239.23 237.11 2.12 (0.89%)
fixed_size_expr_evaluator q11 231.43 229.73 1.70 (0.74%)
fixed_size_expr_evaluator q12 234.25 226.76 7.49 (3.30%)
fixed_size_expr_evaluator q13 1459.40 1485.99 -26.59 (-1.79%)
fixed_size_seq_scan q23 108.44 114.75 -6.31 (-5.50%)
join q29 582.31 626.88 -44.57 (-7.11%)
join q30 10131.99 9926.17 205.82 (2.07%)
join q31 4.41 5.96 -1.55 (-26.01%)
join SelectiveTwoHopJoin 56.67 53.13 3.54 (6.66%)
ldbc_snb_ic q35 2600.74 2538.32 62.42 (2.46%)
ldbc_snb_ic q36 457.30 473.06 -15.76 (-3.33%)
ldbc_snb_is q32 2.76 3.53 -0.77 (-21.85%)
ldbc_snb_is q33 9.98 11.15 -1.18 (-10.56%)
ldbc_snb_is q34 1.26 1.37 -0.10 (-7.49%)
multi-rel multi-rel-large-scan 1407.77 1305.98 101.79 (7.79%)
multi-rel multi-rel-lookup 13.10 19.35 -6.25 (-32.29%)
multi-rel multi-rel-small-scan 76.24 101.76 -25.52 (-25.08%)
order_by q25 135.00 136.65 -1.65 (-1.21%)
order_by q26 472.44 457.93 14.52 (3.17%)
order_by q27 1506.55 1491.74 14.81 (0.99%)
recursive_join recursive-join-bidirection 269.63 284.45 -14.83 (-5.21%)
recursive_join recursive-join-dense 7461.36 7462.05 -0.70 (-0.01%)
recursive_join recursive-join-path 24161.80 24232.52 -70.71 (-0.29%)
recursive_join recursive-join-sparse 1064.01 1076.97 -12.96 (-1.20%)
recursive_join recursive-join-trail 7432.74 7428.25 4.49 (0.06%)
scan_after_filter q01 174.22 176.54 -2.32 (-1.32%)
scan_after_filter q02 159.59 160.29 -0.69 (-0.43%)
shortest_path_ldbc100 q37 81.20 97.58 -16.38 (-16.79%)
shortest_path_ldbc100 q38 385.95 347.67 38.28 (11.01%)
shortest_path_ldbc100 q39 62.23 61.18 1.06 (1.73%)
shortest_path_ldbc100 q40 440.88 427.76 13.12 (3.07%)
var_size_expr_evaluator q03 2106.09 2120.81 -14.72 (-0.69%)
var_size_expr_evaluator q04 2348.60 2331.20 17.40 (0.75%)
var_size_expr_evaluator q05 2612.89 2699.55 -86.66 (-3.21%)
var_size_expr_evaluator q06 1345.91 1386.85 -40.94 (-2.95%)
var_size_seq_scan q19 1466.72 1464.94 1.78 (0.12%)
var_size_seq_scan q20 2631.89 2602.28 29.61 (1.14%)
var_size_seq_scan q21 2323.03 2292.04 30.99 (1.35%)
var_size_seq_scan q22 130.49 126.90 3.59 (2.82%)

@andyfengHKU andyfengHKU merged commit 8d69e48 into master Jan 9, 2025
@andyfengHKU andyfengHKU deleted the refactor-rj-output-writer branch January 9, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyfengHKU @ray6080