Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor table func interface with const params #4670

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Refactor table func interface with const params #4670

merged 2 commits into from
Dec 30, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Dec 29, 2024

Description

See title.

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 17a4121667efc7a6fed3046216199ab200921d5f
Branch commit hash: 4c36d1985efaaaeafc1858c7890430a32a8007d3

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 646.36 649.63 -3.27 (-0.50%)
aggregation q28 11649.23 12222.49 -573.26 (-4.69%)
filter q14 125.37 125.65 -0.28 (-0.22%)
filter q15 127.86 132.25 -4.39 (-3.32%)
filter q16 298.86 307.10 -8.24 (-2.68%)
filter q17 445.81 445.70 0.11 (0.02%)
filter q18 1953.60 1889.74 63.86 (3.38%)
filter zonemap-node 88.60 88.76 -0.16 (-0.18%)
filter zonemap-node-lhs-cast 88.64 88.70 -0.06 (-0.06%)
filter zonemap-node-null 84.68 84.78 -0.10 (-0.12%)
filter zonemap-rel 5663.73 5744.26 -80.53 (-1.40%)
fixed_size_expr_evaluator q07 580.09 579.61 0.48 (0.08%)
fixed_size_expr_evaluator q08 811.97 810.81 1.16 (0.14%)
fixed_size_expr_evaluator q09 812.05 807.91 4.15 (0.51%)
fixed_size_expr_evaluator q10 246.25 243.94 2.31 (0.95%)
fixed_size_expr_evaluator q11 238.39 237.37 1.02 (0.43%)
fixed_size_expr_evaluator q12 234.30 233.42 0.88 (0.38%)
fixed_size_expr_evaluator q13 1451.68 1463.19 -11.50 (-0.79%)
fixed_size_seq_scan q23 123.66 121.48 2.18 (1.80%)
join q29 624.33 586.95 37.39 (6.37%)
join q30 1598.69 1512.47 86.23 (5.70%)
join q31 5.76 5.22 0.54 (10.32%)
join SelectiveTwoHopJoin 54.38 51.45 2.93 (5.70%)
ldbc_snb_ic q35 2546.97 2646.31 -99.35 (-3.75%)
ldbc_snb_ic q36 541.05 553.67 -12.62 (-2.28%)
ldbc_snb_is q32 4.99 2.49 2.50 (100.28%)
ldbc_snb_is q33 12.32 7.57 4.75 (62.73%)
ldbc_snb_is q34 0.99 1.00 -0.01 (-0.67%)
multi-rel multi-rel-large-scan 1314.68 1357.80 -43.13 (-3.18%)
multi-rel multi-rel-lookup 5.15 19.34 -14.19 (-73.38%)
multi-rel multi-rel-small-scan 93.15 88.92 4.23 (4.76%)
order_by q25 137.90 133.17 4.73 (3.55%)
order_by q26 458.26 451.77 6.49 (1.44%)
order_by q27 1462.46 1475.22 -12.76 (-0.87%)
recursive_join recursive-join-bidirection 265.34 285.21 -19.88 (-6.97%)
recursive_join recursive-join-dense 7445.21 7387.35 57.86 (0.78%)
recursive_join recursive-join-path 24081.58 23851.87 229.72 (0.96%)
recursive_join recursive-join-sparse 13898.72 14011.99 -113.27 (-0.81%)
recursive_join recursive-join-trail 7374.08 7347.29 26.79 (0.36%)
scan_after_filter q01 169.43 170.39 -0.96 (-0.56%)
scan_after_filter q02 156.09 156.60 -0.51 (-0.33%)
shortest_path_ldbc100 q37 89.39 81.88 7.51 (9.17%)
shortest_path_ldbc100 q38 330.01 312.01 18.00 (5.77%)
shortest_path_ldbc100 q39 65.50 59.91 5.59 (9.34%)
shortest_path_ldbc100 q40 414.09 432.23 -18.14 (-4.20%)
var_size_expr_evaluator q03 2081.83 2073.43 8.40 (0.41%)
var_size_expr_evaluator q04 2263.36 2169.53 93.82 (4.32%)
var_size_expr_evaluator q05 2626.82 2687.38 -60.56 (-2.25%)
var_size_expr_evaluator q06 1335.21 1353.62 -18.41 (-1.36%)
var_size_seq_scan q19 1469.51 1479.30 -9.80 (-0.66%)
var_size_seq_scan q20 2656.15 2732.75 -76.61 (-2.80%)
var_size_seq_scan q21 2274.83 2325.91 -51.08 (-2.20%)
var_size_seq_scan q22 130.12 129.36 0.76 (0.59%)

@ray6080 ray6080 requested a review from andyfengHKU December 30, 2024 03:03
@ray6080 ray6080 changed the title Refactor table func interface with const Refactor table func interface with const params Dec 30, 2024
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: f22023e17eec579945083de4bf59e42a5bcbfb0e
Branch commit hash: 74b260b8f4a508e9941d160ef35f481a74e25276

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 643.95 664.17 -20.22 (-3.04%)
aggregation q28 11907.01 12269.88 -362.88 (-2.96%)
filter q14 126.00 135.92 -9.93 (-7.30%)
filter q15 126.58 139.09 -12.50 (-8.99%)
filter q16 301.44 328.55 -27.12 (-8.25%)
filter q17 443.98 462.93 -18.95 (-4.09%)
filter q18 1988.97 1978.23 10.74 (0.54%)
filter zonemap-node 88.40 98.15 -9.75 (-9.94%)
filter zonemap-node-lhs-cast 88.71 96.76 -8.04 (-8.31%)
filter zonemap-node-null 84.55 92.88 -8.33 (-8.97%)
filter zonemap-rel 5744.92 5771.15 -26.23 (-0.45%)
fixed_size_expr_evaluator q07 579.15 595.87 -16.72 (-2.81%)
fixed_size_expr_evaluator q08 812.48 831.65 -19.16 (-2.30%)
fixed_size_expr_evaluator q09 811.83 828.98 -17.15 (-2.07%)
fixed_size_expr_evaluator q10 244.22 255.42 -11.20 (-4.39%)
fixed_size_expr_evaluator q11 236.46 248.45 -12.00 (-4.83%)
fixed_size_expr_evaluator q12 233.54 245.60 -12.06 (-4.91%)
fixed_size_expr_evaluator q13 1454.71 1497.09 -42.38 (-2.83%)
fixed_size_seq_scan q23 116.26 126.77 -10.51 (-8.29%)
join q29 587.60 627.64 -40.04 (-6.38%)
join q30 10148.46 10737.06 -588.60 (-5.48%)
join q31 4.40 4.43 -0.02 (-0.51%)
join SelectiveTwoHopJoin 50.35 52.22 -1.87 (-3.59%)
ldbc_snb_ic q35 2585.45 2599.21 -13.76 (-0.53%)
ldbc_snb_ic q36 450.73 471.72 -21.00 (-4.45%)
ldbc_snb_is q32 5.67 7.09 -1.41 (-19.95%)
ldbc_snb_is q33 12.95 12.58 0.37 (2.95%)
ldbc_snb_is q34 1.11 0.87 0.24 (27.60%)
multi-rel multi-rel-large-scan 1330.02 1649.02 -319.00 (-19.34%)
multi-rel multi-rel-lookup 17.54 16.79 0.75 (4.46%)
multi-rel multi-rel-small-scan 103.61 66.46 37.15 (55.89%)
order_by q25 135.82 142.76 -6.94 (-4.86%)
order_by q26 464.10 468.56 -4.46 (-0.95%)
order_by q27 1493.90 1492.88 1.02 (0.07%)
recursive_join recursive-join-bidirection 303.20 284.68 18.52 (6.51%)
recursive_join recursive-join-dense 7376.27 7472.07 -95.80 (-1.28%)
recursive_join recursive-join-path 23727.66 24126.15 -398.49 (-1.65%)
recursive_join recursive-join-sparse 1065.49 1081.40 -15.91 (-1.47%)
recursive_join recursive-join-trail 7354.23 7404.08 -49.85 (-0.67%)
scan_after_filter q01 170.21 180.93 -10.72 (-5.92%)
scan_after_filter q02 155.63 167.08 -11.45 (-6.85%)
shortest_path_ldbc100 q37 96.78 90.89 5.89 (6.48%)
shortest_path_ldbc100 q38 236.27 353.88 -117.61 (-33.24%)
shortest_path_ldbc100 q39 61.27 62.08 -0.81 (-1.30%)
shortest_path_ldbc100 q40 414.52 426.70 -12.18 (-2.85%)
var_size_expr_evaluator q03 2089.85 2090.55 -0.70 (-0.03%)
var_size_expr_evaluator q04 2286.32 2296.73 -10.40 (-0.45%)
var_size_expr_evaluator q05 2601.65 2696.19 -94.53 (-3.51%)
var_size_expr_evaluator q06 1333.29 1370.35 -37.06 (-2.70%)
var_size_seq_scan q19 1453.51 1477.09 -23.57 (-1.60%)
var_size_seq_scan q20 2687.08 2699.58 -12.50 (-0.46%)
var_size_seq_scan q21 2283.00 2333.02 -50.03 (-2.14%)
var_size_seq_scan q22 127.21 130.40 -3.19 (-2.44%)

@ray6080 ray6080 merged commit 48275a6 into master Dec 30, 2024
@ray6080 ray6080 deleted the table-func branch December 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ray6080 @andyfengHKU