Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reload timestamps to metrics #99

Merged
merged 7 commits into from
Apr 21, 2023
Merged

Add reload timestamps to metrics #99

merged 7 commits into from
Apr 21, 2023

Conversation

excalq
Copy link
Contributor

@excalq excalq commented Apr 21, 2023

Resolves #95. Adds pipeline reload timestamp metrics:

Note, this includes changes from PR #94 and #98, as there is dependency on the new PipelineReloadResponse struct.

@codecov
Copy link

codecov bot commented Apr 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (81dfaac) 100.00% compared to head (3f13a93) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          427       434    +7     
=========================================
+ Hits           427       434    +7
Impacted Files Coverage Δ
collectors/nodestats/pipeline_subcollector.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuskoman
Copy link
Owner

I'm removing --version-sort, as i dont understand its purpose in these metrics. Feel free to open another issue with that if this is required for some reason

@kuskoman kuskoman force-pushed the excalq/95-reload-timestamps branch from 5b9cb53 to a68aa97 Compare April 21, 2023 09:24
@kuskoman kuskoman changed the title #95 reload timestamps Add reload timestamps to metrics Apr 21, 2023
@kuskoman kuskoman force-pushed the excalq/95-reload-timestamps branch from a68aa97 to 3928375 Compare April 21, 2023 09:26
@kuskoman
Copy link
Owner

ah, just realised it is for _number ones, reverting it

@kuskoman kuskoman force-pushed the excalq/95-reload-timestamps branch from 3928375 to a191d62 Compare April 21, 2023 09:46
@kuskoman kuskoman force-pushed the excalq/95-reload-timestamps branch from 22caaa6 to 3f13a93 Compare April 21, 2023 10:02
@kuskoman kuskoman merged commit a4321ac into kuskoman:master Apr 21, 2023
@excalq
Copy link
Contributor Author

excalq commented Apr 21, 2023

ah, just realised it is for _number ones, reverting it

Correct, and that should have been part of #90 as it fixes the sort order of logstash_stats_process_cpu_load_average_{1,5,15}m to keep 15m last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Reload Timestamp Metrics
2 participants
@excalq @kuskoman