Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds DOCKER_IMG ENV to Makefile #92

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Adds DOCKER_IMG ENV to Makefile #92

merged 1 commit into from
Apr 22, 2023

Conversation

excalq
Copy link
Contributor

@excalq excalq commented Apr 20, 2023

docker buildx needs --push to do anything useful. And I'm pushing to ECR, which requires full image path naming. So this adds DOCKER_IMG which will default to logstash-exporter.

@excalq excalq marked this pull request as ready for review April 20, 2023 15:11
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6a07b31) 100.00% compared to head (f9e3ffb) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          427       427           
=========================================
  Hits           427       427

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuskoman
Copy link
Owner

@excalq why you are not able to do docker tag logstash-exporter , then push it?

@excalq
Copy link
Contributor Author

excalq commented Apr 21, 2023

@excalq why you are not able to do docker tag logstash-exporter , then push it?

AWS ECR requires the image name to be in the format of <account_number>.dkr.ecr.<aws_region>.amazonaws.com/logstash-exporter for docker push to push to our internal ECR registry, which we use for our K8s cluster.

@excalq
Copy link
Contributor Author

excalq commented Apr 21, 2023

And the docker buildx produced images are "special", and not loaded into the local docker images location, hence needing --push.

@kuskoman
Copy link
Owner

kuskoman commented Apr 21, 2023 •
edited
Loading

@excalq same for github, i just do docker tag logstash-exporter <ACTUAL_IMAGE_NAME> && docker push <ACTUAL_IMAGE_NAME>, i was just curious why this is not possible for AWS
Will probably take a look on it tommorow

Edit: ah, now i understand

@kuskoman kuskoman merged commit 5683d2a into kuskoman:master Apr 22, 2023
@excalq excalq deleted the excalq/makefile-docker branch April 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@excalq @kuskoman