Add load averages to metrics #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excalq
commented
Apr 20, 2023
| @@ -38,11 +38,14 @@ type NodestatsCollector struct { | |||
|
|
|||
| JvmUptimeMillis *prometheus.Desc | |||
|
|
|||
| ProcessOpenFileDescriptors *prometheus.Desc | |||
There was a problem hiding this comment.
Note, go fmt did a lot of whitespace changes...
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 420 427 +7
=========================================
+ Hits 420 427 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kuskoman
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following metrics, sourced from Logstash's API:
Additionally, tests,
metric_names.txtand the README have updates.scripts/add_metrics_to_readme.shhas a change to provide Bash 3.x (MacOS) and ZSH compatibility, asmapfiledoes not exist outside of Bash 4+. (Lmk if this should be in a separate PR).