Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic Helm chart for the application #66

Merged
merged 13 commits into from
Apr 12, 2023
Merged

Add basic Helm chart for the application #66

merged 13 commits into from
Apr 12, 2023

Conversation

kuskoman
Copy link
Owner

@kuskoman kuskoman commented Mar 24, 2023 •
edited
Loading

This PR will serve as a kind of a todo:

  • implement basic resources in chart
  • create pipeline for the chart:
    • add chart linting
    • add chart testing
    • consider (and add if possible) chart testing on real kubernetes
  • add versioning chart for the chart: (Implement application and chart versioning script #83)
    • version the chart along with main tags
    • version the app inside chart with main tags
  • publish the charts somehow and somewhere
  • modify README.md to include information about helm chart usage

Once merged this PR closes #17 (not literally, as this won't serve as a sidecar)

edit: Issues will be created from tasks that aren't closed

@kuskoman kuskoman marked this pull request as draft March 24, 2023 21:22
@kuskoman
Copy link
Owner Author

kuskoman commented Mar 24, 2023 •
edited
Loading

This resource may turn out to be useful to test chart: https://blog.ediri.io/how-to-unit-test-your-helm-charts

@kuskoman
Copy link
Owner Author

For releasing chart I may take a look on this guide: https://medium.com/@mattiaperi/create-a-public-helm-chart-repository-with-github-pages-49b180dbb417

@codecov
Copy link

codecov bot commented Mar 24, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (21fefa4) 100.00% compared to head (e196540) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          400       400           
=========================================
  Hits           400       400

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuskoman
Copy link
Owner Author

For testing inside k8s kind project may be the best choice

https://github.com/helm/kind-action

@kuskoman kuskoman mentioned this pull request Apr 1, 2023
Closed
@excalq
Copy link
Contributor

excalq commented Apr 11, 2023

Contributed a PR to this branch: #74. Feel free to change the base, as it's not master.

@kuskoman
Copy link
Owner Author

Closed some of the things.
What I want to address in other issues/PRs:

  • unit testing chart
  • integration testing in kind

This PR requires:

  • versioning
  • publishing
    to be considered as ready

@kuskoman
Copy link
Owner Author

Actually, I am going to merge this one, since it already has a lot of changes and address rest of checkboxes in other issues

@kuskoman kuskoman marked this pull request as ready for review April 12, 2023 08:59
@kuskoman kuskoman changed the title Add Helm chart for the application Add basic Helm chart for the application Apr 12, 2023
@kuskoman kuskoman merged commit 9415663 into master Apr 12, 2023
@kuskoman kuskoman deleted the helm-chart branch April 12, 2023 09:01
This was referenced Apr 12, 2023
Closed
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart: template to be used as a side car for this exporter when installing logstash chart from bitnami
2 participants
@kuskoman @excalq