-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Helm chart: labels, pod monitor, additional env vars #384
Conversation
@JulienOrain for some reason i cannot modify the PR
README:
schema.json:
|
@JulienOrain I created branch pr-384 so you can copy changes |
hello @kuskoman ! |
seems like pipeline is complaining about newline, could you add/remove it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1 #384 +/- ##
==========================================
- Coverage 93.60% 93.14% -0.46%
==========================================
Files 15 16 +1
Lines 641 686 +45
==========================================
+ Hits 600 639 +39
- Misses 41 46 +5
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
hello @kuskoman ! |
hello |
hello @kuskoman |
@JulienOrain done |
Hello
Some enhancements for the helm chart V1 :