node stats: support infinity #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbs would you mind adding a test to the new type that you created? |
|
Still need to update the tests, will work on that. Guess I also need to target v2/master with this PR, what is the process for that? Shall I open a 2nd PR after this lands? edit: you're too fast @kuskoman :D |
|
v2 is way less urgent |
|
I pushed a fix so the tests pass, but let me figure out how to test the infinity values as well |
These values are often float64 but sometimes a string, from the api docs[1]: > An "Infinity" value for a given flow window indicates that worker > millis have been spent without any events completing processing This adds a custom float64 type to enable the use of a custom marshaller. [1]: https://www.elastic.co/guide/en/logstash/current/node-stats-api.html
|
done |
kuskoman
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values are often float64 but sometimes a string, from the api docs1:
This adds a custom float64 type to enable the use of a custom marshaller.
fixes: #372