Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement startup manager with hot reload #360

Merged
merged 48 commits into from
Nov 7, 2024

Conversation

satk0
Copy link
Collaborator

@satk0 satk0 commented Oct 3, 2024

No description provided.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 40.47059% with 253 lines in your changes missing coverage. Please review.

Project coverage is 78.25%. Comparing base (119ace0) to head (e1c1a27).
Report is 151 commits behind head on master.

Files with missing lines Patch % Lines
internal/startup_manager/startup_manager.go 0.00% 165 Missing ⚠️
internal/file_utils/file_test_utils.go 32.81% 30 Missing and 13 partials ⚠️
internal/file_watcher/file_watcher.go 68.00% 17 Missing and 7 partials ⚠️
cmd/exporter/main.go 0.00% 10 Missing ⚠️
pkg/config/slog_config.go 65.21% 8 Missing ⚠️
internal/file_watcher/file_hash.go 80.00% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (119ace0) and HEAD (e1c1a27). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (119ace0) HEAD (e1c1a27)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #360       +/-   ##
===========================================
- Coverage   93.60%   78.25%   -15.36%     
===========================================
  Files          15       21        +6     
  Lines         641     1214      +573     
===========================================
+ Hits          600      950      +350     
- Misses         41      243      +202     
- Partials        0       21       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuskoman kuskoman force-pushed the satk0-hot-reload branch 3 times, most recently from c5360ec to 9f16aca Compare October 8, 2024 14:21
@kuskoman kuskoman changed the title Implement hot reload Implement startup manager with hot reload Nov 7, 2024
@kuskoman kuskoman merged commit 754e0c6 into kuskoman:master Nov 7, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants