Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intendation issue in Helm chart #227

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix intendation issue in Helm chart #227

merged 1 commit into from
Jan 19, 2024

Conversation

frankhetterich
Copy link
Contributor

@frankhetterich frankhetterich commented Jan 19, 2024 •
edited by kuskoman
Loading

  • fix intendation in line 9
  • change indent to nindent in line 10

Closes #226

@frankhetterich
fix intendation issue
ad7cb84 
* fix intendation in line9
* change indent to nindent in line 10
@kuskoman kuskoman changed the title fix intendation issue Fix intendation issue in Helm chart Jan 19, 2024
@kuskoman kuskoman self-requested a review January 19, 2024 07:58
@kuskoman kuskoman added the bug Something isn't working label Jan 19, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ef6a94) 100.00% compared to head (ad7cb84) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          774       774           
=========================================
  Hits           774       774

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kuskoman
kuskoman approved these changes Jan 19, 2024
View reviewed changes
Copy link
Owner

@kuskoman kuskoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed locally, it seems to work properly

@kuskoman
Copy link
Owner

@frankhetterich unless you are using the exporter 2.x.x prerelease, you may want to keep using chart from v1 branch
I will check it for a similar problem in a moment

@kuskoman kuskoman merged commit 65eafef into kuskoman:master Jan 19, 2024
17 checks passed
@frankhetterich frankhetterich deleted the bugfix/fix-intendation-issue-in-service.yaml branch January 19, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuskoman kuskoman kuskoman approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue in HELM Chart service.yaml
2 participants
@frankhetterich @kuskoman