Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes code related to #202
Basically, since all instances now have hostname attached, a simple proxy should be able to solve the issue
I took some time to implement custom labeling, but it required way more logic than it gives benefits:
a. verifying label consistency
b. sorting label keys
c. sorting label values according to keys order
I believe there are existing solutions allowing to relabel prometheus metrics.
In most cases hostname label alone should be sufficient, but if you are running multiple instances monitoring for example a local url you may consider using combination of both exporter and logstash address as a base for relabeling