Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add building multi-arch image to pipeline #173

Merged
merged 9 commits into from
Sep 8, 2023
Merged

Add building multi-arch image to pipeline #173

merged 9 commits into from
Sep 8, 2023

Conversation

arousseau-coveo
Copy link
Contributor

Fix Issue #136

Run this on my fork buildx seems to be working but I can't test the rest of the pipeline integrations
https://github.com/arousseau-coveo/logstash-exporter/actions/runs/6027420067/job/16352636745

@kuskoman kuskoman changed the title Make docker build multi arch Add building multi-arch image to pipeline Aug 30, 2023
@kuskoman kuskoman added docker Pull requests that update Docker code github_actions Pull requests that update GitHub Actions code labels Aug 30, 2023
@kuskoman kuskoman linked an issue Aug 30, 2023 that may be closed by this pull request
linux/arm64 Images for Docker Hub #136
Closed
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@arousseau-coveo
Copy link
Contributor Author

@kuskoman This one is an easy one I think.
Would you have some time to review it ?

@kuskoman
Copy link
Owner

This failed, because you are trying to push the image before logging to docker.
You need to repeat this command two times- first time just to test building (without --push) and second time on release
I cam probably do it myself next week if needed

@kuskoman
Copy link
Owner

Error:

Run docker save logstash-exporter:latest | gzip > logstash-exporter.tar.gz
Error response from daemon: reference does not exist

@arousseau-coveo
Copy link
Contributor Author

Alright with further reading seems like the way it was before is still not supported: docker/buildx#166

I have implemented a fix mentionned in the thread

@arousseau-coveo
Copy link
Contributor Author

Alright @kuskoman I did my best but the last error in the helm test integrations is hard for me to understand/solve. I try to run all the step on my end and it deployed without issue in my kind cluster.

I would appreciate bit of help when you have time do to so.
Thanks

@kuskoman kuskoman merged commit 90bdfa2 into kuskoman:master Sep 8, 2023
@kuskoman kuskoman mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker Pull requests that update Docker code github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linux/arm64 Images for Docker Hub
2 participants
@arousseau-coveo @kuskoman