Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grafana to local development stack #157

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

kuskoman
Copy link
Owner

In order to make debugging problems with the exporter easier I am adding Grafana to the local development stack

@kuskoman kuskoman added the docker Pull requests that update Docker code label Aug 12, 2023
@kuskoman kuskoman requested a review from excalq August 12, 2023 14:21
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (38acc61) 100.00% compared to head (f46a2c4) 100.00%.

❗ Current head f46a2c4 differs from pull request most recent head fa7b7f4. Consider uploading reports for the commit fa7b7f4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          589       589           
=========================================
  Hits           589       589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuskoman
Copy link
Owner Author

@excalq since I added grafana config here do you consider moving grafana dashboard here?
To be clear, I am totally happy with the dashboard being in a separate repo, especially since yours is mainly k8s focused and the development setup is fully in docker-compose, so don't treat it as a request,

@kuskoman kuskoman force-pushed the grafana-local-stack branch from 3f2a938 to 75f3912 Compare August 12, 2023 15:12
@kuskoman kuskoman force-pushed the grafana-local-stack branch from f46a2c4 to fa7b7f4 Compare August 12, 2023 18:04
@kuskoman kuskoman merged commit 73bebcb into master Aug 17, 2023
@kuskoman kuskoman deleted the grafana-local-stack branch August 17, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant