Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin_id collisions #137

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix plugin_id collisions #137

merged 1 commit into from
Jun 16, 2023

Conversation

kuskoman
Copy link
Owner

@kuskoman kuskoman commented Jun 16, 2023

Fix collisions by not truncating their uuids
Closes #134

@kuskoman kuskoman added the bug Something isn't working label Jun 16, 2023
@kuskoman kuskoman requested a review from excalq June 16, 2023 08:36
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (841f280) 100.00% compared to head (2ebcfe4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          536       525   -11     
=========================================
- Hits           536       525   -11     
Impacted Files Coverage Δ
collectors/nodestats/pipeline_subcollector.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuskoman kuskoman merged commit 79d685a into master Jun 16, 2023
@kuskoman kuskoman deleted the fix-plugin-id-collisions branch June 16, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin_id is most likely cut and it make application fail
1 participant